ledger-live-common icon indicating copy to clipboard operation
ledger-live-common copied to clipboard

Added logo to IndexCoop Tokens

Open ripples3 opened this issue 4 years ago • 4 comments
trafficstars

Context (issues, jira)

None

Description / Usage

Added logo for Alchemist https://etherscan.io/token/0x88acdd2a6425c3faae4bc9650fd7e27e0bebb7ab

Expectations

  • [ ] Test coverage: The changes of this PR are covered by test. Unit test were added with mocks when depending on a backend/device.
  • [x] No impact: The changes of this PR have ZERO impact on the userland. Meaning, we can use these changes without modifying LLD/LLM at all. It will be a "noop" and the maintainers will be able to bump it without changing anything.

ripples3 avatar Oct 22 '21 14:10 ripples3

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/ledgerhq/ledger-live-common/ENKBqtXBTVXCG1KF7kmMYyG3viZw
✅ Preview: https://ledger-live-common-git-fork-ripples3-mist-ledgerhq.vercel.app

vercel[bot] avatar Oct 22 '21 14:10 vercel[bot]

any update on this? I have also requested the ledger to add tokens here. https://developers.ledger.com/docs/token/erc20-bep20/#2-how-to-get-my-token-listed

ripples3 avatar Nov 29 '21 20:11 ripples3

Thanks for the contribution. could you merge master in? we have extra test that do some checks to ensure icons are fine. Thanks

gre avatar Dec 07 '21 14:12 gre

@gre I merge master in. Let me know if you have concerns.

ripples3 avatar Dec 09 '21 14:12 ripples3