Cristian Le

Results 1005 comments of Cristian Le

> How complex do you think it would get? Complexity I don't think it would be complex, but it would require quite some changes to separate from cog's python module...

See: https://github.com/python/cpython/blame/3.13/Lib/dataclasses.py#L1035-L1044 It seems that was always meant to be like that, but it was not correctly checked before for multiple inheritance

@hgrecco would it be ok to move them all to `frozen=False` in order to unblock this issue? The doctest failure is fairly weird, because if you simply `raise pint.errors.UndefinedUnitError("anything")` you...

I have *finally* figured out the issue. The issue is with double inheriting with `AttributeError` which is trying to set `name = property` https://github.com/hgrecco/pint/blob/2839f6e23f48dd393c375c44581574afec04ff43/pint/errors.py#L133-L134 https://github.com/python/cpython/blob/3024b16d51bb7f74177c5a5038cc9a56fd2b26bd/Objects/exceptions.c#L2400-L2404 Removing that inheritance made the...

@khaeru Run the `sphinx-build` command in a Python 3.13 environment. That is where you will encounter the error

@tacaswell I think you are experiencing a different issue. Either it is an issue with the other `dataclass` objects, in which case you should be able to reproduce with 3.12,...

> My judgement is that removing `AttributeError` from the inheritance is a major API break as if you have > > ```python > try: > some_code_that_raises_UndefinedUnitError() > except AttributeError: >...

> I should start by apologizing from showing up randomly and having a bunch of Strong Opinions, but hopefully Ryan will vouch for me ;) No worries, and you are...

Ultimately any approach is welcome as long as it unblocks this issue and it seems like the user would have a surprise regardless of the solution. Also worth considering that...

Can't really replicate it: ```console $ python3.13 -m venv venv-3.13 $ source venv-3.13/bin/activate (venv-3.13) lecris@Tuxedo:~/tmp/python$ pip install pint Collecting pint Downloading Pint-0.24.4-py3-none-any.whl.metadata (8.5 kB) Collecting platformdirs>=2.1.0 (from pint) Downloading platformdirs-4.3.6-py3-none-any.whl.metadata...