Cristian Le

Results 833 comments of Cristian Le
trafficstars

First, let me check that these changes pass the tests on Fedora, although I think these are disabled by: ```spec %check # * These tests are skipped because they required...

@tessus can you drop the first commit so that this PR is more focused? I've made #2065 instead for that.

> @tessus can you drop the first commit so that this PR is more focused? I've made #2065 instead for that. I'm concerned that the revert commit will do an...

I just read the comments again. It sounds like this can be fixed by using the `ring` feature of `rustls` instead. Wouldn't it work if the dependency is made to...

Oh right, didn't see that #2382 basically does that. :crossed_fingers:

From what I've heard this is just how it's supposed to be designed where the library propagate the options until it reaches a leaf. Probably a similar design to `axum-server`...

@tessus could you try to rebase the PR and pull in the latest `aws-lc`? I checked the issues recently and it should be easy to fix if we force `bindgen`...

It seems it needs `aws-ls-sys = { feature="bindgen" }` (maybe the same for `aws-ls`) in order to force it to compile for illumos. Otherwise it seems that `aws-ls` does support...

Fwiw, upstream is now aware of the illumos issues: https://github.com/aws/aws-lc-rs/pull/709, though it seems to me an issue with `cross` image not packaing c standard library. :+1: for the removal of...

An update from `aws-lc-sys`. It seems the builds could be unblocked by providing `BINDGEN_EXTRA_CLANG_ARGS=-I/usr/include/x86_64-linux-gnu` as an environment variable. It sounds weird to me adding that to a cross-compiling build, but...