Cristian Le

Results 1012 comments of Cristian Le

You need to compile `master` branch of cmake rn

+1 for this, but add `tox.ini` metadata, and delete `MANIFESTS.in`. I would also suggest moving to `src-layout`

I've personally had a few problems when testing python packages using virtual environment with contaminations with the test environment.

Maybe should edit this issue to track what are the missing parts. I will copy the suggestion from `spglib`: - [ ] Add a [`CMAKE_INSTALL_RPATH`](https://cmake.org/cmake/help/latest/variable/CMAKE_INSTALL_RPATH.html) pointing to the library dependencies....

> #2895, as you've seen, adds `NETCDF_` as a prefix to address the concern of conflicting variables Yep just saw that. Do you prefer to have this finished first, since...

I did not check the CI in detail, but the CI should mimic the user's experience, i.e. how would a user install `HDF5` (preferably without compiling by hand). From what...

I can help with reviewing. Also I have a [cmake-template](https://github.com/LecrisUT/CMake-Template) with many of the points there, feel free to copy anything needed from there.

Why not `mock_call` and `spy_call`. I think `expect`/`check` language could clash with other plugins like [`pytest-chcek`](https://github.com/okken/pytest-check). The only thing is that the `and_*` syntax no longer fits well (neither with...

This seems quite tricky when doing with `__new__` I've tried the following with no success ```python fake_command = flexmock(Command).should_receive("run").once() ( flexmock(Command).should_receive("__new__") .with_args("main_command", str, str) .and_return(fake_command) .once() ) ``` So far...

What's the status on this in 2024. From what I manage to read on the issue it should only affect if you manually call `felxmock_teardown`, and not something like providing...