foundry-vtt-types icon indicating copy to clipboard operation
foundry-vtt-types copied to clipboard

Update ClientSettings

Open JPMeehan opened this issue 1 year ago • 3 comments
trafficstars

resources/app/client/core/settings.js

JPMeehan avatar Aug 05 '24 18:08 JPMeehan

Possibly blocked by #1606 and/or will cause merge issues.

JPMeehan avatar Aug 05 '24 19:08 JPMeehan

I've added support for DataModels and DataFields so this shouldn't be blocked anymore.

LukeAbby avatar Oct 19 '24 20:10 LukeAbby

Note there are some unresolved questions with settings:

  • Is it intentional that providing something like a SetField basically behaves identically to an ArrayField?
  • When does undefined get replaced with null? In all cases? What about functions, data models, data fields, etc.? I can tell that there's some substitution of undefined into null but I can't tell what cases it applies to.

JPMeehan provided these Foundry issues: https://github.com/foundryvtt/foundryvtt/issues/11613 https://github.com/foundryvtt/foundryvtt/issues/11629

LukeAbby avatar Oct 19 '24 20:10 LukeAbby