foundry-vtt-types icon indicating copy to clipboard operation
foundry-vtt-types copied to clipboard

Implement GetDataReturnType across all subclasses of Application

Open JPMeehan opened this issue 1 year ago • 2 comments
trafficstars

  1. The helper GetDataReturnType should be used for the invocation of all instances of getData
  2. The interface should be named Data and inside the namespace for the class, e.g. ActorSheet.Data

Related, all instances of _renderInner should be typed as ReturnType<this["getData"]>

JPMeehan avatar Jun 08 '24 06:06 JPMeehan

Realized I didn't post here. But for visibility, I'm going to give this a whirl.

joneshf avatar Sep 12 '24 11:09 joneshf

As of v13 Testing 1, here are the guaranteed survivors that need to be handled

  • [ ] Application
  • [ ] FormApplication
  • [ ] DocumentSheet
  • [ ] ActorSheet
  • [ ] ItemSheet
  • [ ] JournalSheet
  • [ ] JournalPageSheet & subclasses
  • [ ] Dialog

Unknown survivors

  • AdventureImporter (request by premium creators to add back in)

Ticketed to be migrated in a pending release

  • [ ] Filepicker

Staff have promised will be migrated by stable

  • [ ] CameraViews
  • [ ] InstallPackage
  • [ ] SettingsConfig
  • [ ] SetupPackages
  • [ ] AVConfig
  • [ ] DiceConfig
  • [ ] DefaultSheetsConfig
  • [ ] FontConfig
  • [ ] PackageConfiguration
  • [ ] DependencyResolution
  • [ ] KeybindingsConfig
  • [ ] ModuleManagement
  • [ ] ToursManagement
  • [ ] WorldConfig

JPMeehan avatar Feb 13 '25 06:02 JPMeehan