Twelveish icon indicating copy to clipboard operation
Twelveish copied to clipboard

Twelveish 10

Open augustuen opened this issue 4 years ago • 2 comments

Fixes #10 by adding missing capitalization of nouns in the german translation. Also does toLowerCase() before the output of capitalise2().

augustuen avatar Jan 03 '21 21:01 augustuen

Capitalization looks fine, words like "halb" or any number should remain in lower case (as is).

To be 100% correct, the first word should be capitalized as well - I had already forked the repo to do this but later realized that using the existing option should work just fine as well.

msix81 avatar Jan 04 '21 18:01 msix81

To be 100% correct, the first word should be capitalized as well - I had already forked the repo to do this but later realized that using the existing option should work just fine as well.

Yup, unless the user specifically chooses all lowercase or all uppercase, the first word will always have the first letter capitalized. That was already built-in and so didn't need to be amended in this PR.

There is still an issue with all worlds title case though, where certain words (like "nach" and "so") aren't capitalized since they're not recognized as separate words.

augustuen avatar Jan 04 '21 20:01 augustuen