Langmans

Results 24 comments of Langmans

HHVM fails, but shouldn't composer have "phpunit/phpunit:*"? Also, I don't see any use of mockery in your tests at the moment...

1) Totally forgot tabs :) Also, didn't see any editorconfig (http://editorconfig.org/) 2) item id's are supposed to be unique, so that's why I added return statements. But it seems I...

Also, there is this: $item = $collection->makeItem('Example', '/example'); $collection->addItemInstance($item, 10); $item2 = $collection->makeItem('Example', '/example'); $collection->addItemInstance($item2, 10); $collection->removeItem('example'); // $item2 is deleted now, but is $item1 also deleted? Adding $item2 should...

Ok, disregard this PR. I will redo the changes and submit a new PR.

Is there anything else that you are using in favor of this?

How many times would it happen that you need a table name ending with 'List'? A solution would be to make this configurable: ```php $name = preg_replace('/'.preg_quote($this->list_suffix, '/') .'$/', '',...

To do this, one would: 1. Add queryEndCallback in a subclass of LessQL\Database. 2. Find usages of onQuery in LessQL\Database. 3. Overrule those methods in the subclass. https://gist.github.com/rubenvincenten/ef8aaa32a0e413592c8df74ba7ae910e This should...

Just wrote this little snippet: https://gist.github.com/rubenvincenten/78963552b6da0045b5e4bd99d243ceb0#file-convention-php If a `ConventionAdapterInterface` with `getPrimaryKey`, `getReferencingColumn` and `getBackReferencingColumn` could be added that'd be great :) In `__construct` you'd add a second parameter typehinted by...

I don't want to rely on the php gettext extension. I'm using that extractor to compile all the twig files and then capture the compiled php classes. Extracting from twig...

:+1: :point_up: Leafo/lessphp#531 hasn't been active since may last year, not sure on how much munee is relying on lessphp but [less.php](https://github.com/oyejorge/less.php) seems to be having source map support, and...