Bookshelf-Reader-API icon indicating copy to clipboard operation
Bookshelf-Reader-API copied to clipboard

Great job! Thank you. I wish to know why you decided to resize the images to 500 pixels.

Open chatulBamagafaeim opened this issue 4 years ago • 3 comments

Thank you for your great code here. When I tried to use Google Vision API - the results wasn't accurate because of the resize. Is it possible to disable the resize? Changing the width by hand cause the algorithm to be less effective. Thanks.

chatulBamagafaeim avatar Nov 10 '21 19:11 chatulBamagafaeim

Hey @chatulBamagafaeim! I think we can. Currently the resizing code is directly applied on the images being saved to the database. We can instead store multiple version of the image as per our need. Although, this will require some work. I would appreciate if you could propose something.

Again, I think it's okay to pass inaccurate text to the scrappers. Since scrapper is doing a google search, it will find the correct book eventually.

LakshyaKhatri avatar Nov 16 '21 14:11 LakshyaKhatri

I increased the numbers from 500px to 1500px. Also increased this https://github.com/LakshyaKhatri/Bookshelf-Reader-API/blob/master/spine_detection.py#L47 to 65. It worked fine but I think it's not enough. What do you think?

chatulBamagafaeim avatar Nov 25 '21 18:11 chatulBamagafaeim

Thanks for investing and digging deeper in it. At that time 500px worked for me. I'm thinking of going with having different versions of image (155px, 500px, 1500px and so on...). This will give people more control over what kind of result they want.

And I see, the overlapping lines thing is also depending on the image size, probably hardcoding values for each size will do the job for now. We can later find something more robust.

LakshyaKhatri avatar Nov 27 '21 15:11 LakshyaKhatri