maple-ir icon indicating copy to clipboard operation
maple-ir copied to clipboard

Published 20 hours ago • verified publisher icon LLVM-but-worse

Switch to slf4j

Open xxDark opened this issue 3 years ago • 7 comments

Title I wonder if it is possible to get rid of log4j dependency, so the project can be used more easily.

xxDark avatar Jan 04 '22 01:01 xxDark

I will look at this tomorrow. Thanks for your contribution

On Mon, Jan 3, 2022 at 20:42 xxDark @.***> wrote:

Title I wonder if it is possible to get rid of log4j dependency, so the project can be used more easily.

You can view, comment on, or merge this pull request online at:

https://github.com/LLVM-but-worse/maple-ir/pull/2 Commit Summary

File Changes

(11 files https://github.com/LLVM-but-worse/maple-ir/pull/2/files)

Patch Links:

  • https://github.com/LLVM-but-worse/maple-ir/pull/2.patch
  • https://github.com/LLVM-but-worse/maple-ir/pull/2.diff

— Reply to this email directly, view it on GitHub https://github.com/LLVM-but-worse/maple-ir/pull/2, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5NBPL3NIECNN6J7Q7WVEDUUJGA5ANCNFSM5LGLPRUA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

rcx avatar Jan 04 '22 01:01 rcx

Pretty sure there’s more changes required as the logger is used quite literally everywhere

terminalsin avatar Jan 04 '22 11:01 terminalsin

Pretty sure there’s more changes required as the logger is used quite literally everywhere

I'm using this branch locally, and it works fine. upd: just checked, no log4j references were found

xxDark avatar Jan 04 '22 11:01 xxDark

Will check how the output looks during the weekend

terminalsin avatar Jan 05 '22 00:01 terminalsin

Info

Current branch has no implementation, causing the logger to fallback to… nothing. It's best to stick with Log4j as of now (Legacy is unaffected and if it happens to be in any case scenario, we'll just upgrade to latest)

terminalsin avatar Jan 08 '22 13:01 terminalsin

It is up to the user to select the implementation. So, to whoever uses this library & however writes an application. That is really the whole point. The library itself should not bundle any implementation.

xxDark avatar Jan 08 '22 13:01 xxDark

It is up to the user to select the implementation. So, to whoever uses this library & however writes an application. That is really the whole point. The library itself should not bundle any implementation.

I see. Alright here's what I think is best to do: push usage of SLF4j in the parent context and add a Log4j implementation in the main package. I'll make the changes asap

terminalsin avatar Jan 08 '22 14:01 terminalsin