Open-Assistant
Open-Assistant copied to clipboard
LAION-AI
Added Hindi and Japanese Translation
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
In common.json line 43 and 44 are duplicate translations of "trollboard", and the first lacks the final quotation mark and comma.
In index.json line 4 lacks the final comma.
In labelling.json line 19 and 65 and lacks the final comma. Line 67 has quoted English terms, but JSON interprets the double quotation marks as a stop. Using escape sequences (a \ before each ") should work.
Line 5 in tos.json should not have a final comma.
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
@LarsEJonasson all fixed and i also can translate to japanese but there isn't any jp folder should i do it?
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
@LarsEJonasson all fixed and i also can translate to japanese but there isn't any jp folder should i do it?
You still have some formatting issues with tasks.json. If you have Python you can run 'pre-commit run --all-files' on your local computer and it will correct them. For example the spaces between " and : are missing. You also have three initial spaces at each line, but it should be two.
As for more translations, the more the better.
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
:x: pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md
Japanese files should be under the ja directory, not jp.
Thank you for your contribution!
Japanese files should be under the ja directory, not jp.
Do i need to fix it? @GuilleHoardings
I think that it doesn't work if you don't fix it. As far as I know, the framework looks in the directory that matches the locale, and the locale for Japan is ja. Have you tested it?
I think that it doesn't work if you don't fix it. As far as I know, the framework looks in the directory that matches the locale, and the locale for Japan is
ja. Have you tested it?
nope, I'm just renaming to ja
Ok, thank you. I've received another proposal for the Japanase translation, and the submitter merged it with yours. I'll submit as an update when yours is merged.