LuaSnip icon indicating copy to clipboard operation
LuaSnip copied to clipboard

add healthcheck

Open znd4 opened this issue 1 year ago • 1 comments

Hi, I wasn't sure if the way I'd installed jsregexp was working, so I've tried to implement a :checkhealth. Let me

I'm not sure if I've formatted the messages properly. Also, on my machine the require("luasnip.util.jsregexp") raises an exception instead of returning false, but I don't think that that's an issue unless luasnip needs more than one check in the future.

znd4 avatar Mar 26 '24 14:03 znd4

~~FWIW, I've tried to install jsregexp with home-manager's extraLuaPackages, and this is what I see in the new checkhealth entry:~~

EDIT: nevermind, the healthcheck worked once I switched to master

znd4 avatar Mar 26 '24 14:03 znd4

Hey, that's pretty cool, thank you! (the failing tests are unrelated to these changes ;) )

L3MON4D3 avatar Apr 01 '24 13:04 L3MON4D3

since jsregexp is optional, it is better to replace error with warning.

mathjiajia avatar Apr 01 '24 14:04 mathjiajia

Ay, thanks for the suggestions, good points :+1: I'll amend them :) See 79cc25c3

L3MON4D3 avatar Apr 01 '24 17:04 L3MON4D3