react-native-side-menu icon indicating copy to clipboard operation
react-native-side-menu copied to clipboard

Published 20 hours ago • verified publisher icon Kureev

added maxDraggingOffset property

Open acresta88 opened this issue 9 years ago • 6 comments

added maxDraggingOffset property to set the maximum value for the dragging gesture. To avoid that the user can drag more than the menu size and show a white unwanted background. By default set to 0 so that the user can drag only until the full menu is shown, but settable in case that dragging behaviour should be like before.

acresta88 avatar May 03 '16 15:05 acresta88

Would love this...

tomauty avatar May 04 '16 19:05 tomauty

Sorry for the so late review. Can you please add some easing function there? I.e. when you drag close to the offset, drag velocity goes down to zero near the offset value.

Kureev avatar Oct 05 '16 13:10 Kureev

@Kureev are you planning to merge this?

lukas1994 avatar Nov 23 '16 11:11 lukas1994

?

lukas1994 avatar Dec 15 '16 09:12 lukas1994

@lukas1994 Hi, unfortunately I didn't have time to add the easing function that @Kureev asked for, the new commits above where just because of some problem on android when locking the orientation, so quite unrelated to the dragging offset. So either you wait a bit more (probably new year) for it, or maybe @Kureev can add that the maxDraggingOffset property without easing function :)

acresta88 avatar Dec 15 '16 10:12 acresta88

For anyone that's still looking for this - I've forked and added this functionality to https://github.com/gsdatta/react-native-side-menu. I also converted it to typescript. I have yet to get it onto NPM, but if anyone wants to open a PR to set up the package correctly I'm glad to publish it.

gsdatta avatar Jul 04 '19 19:07 gsdatta