react-native-navbar icon indicating copy to clipboard operation
react-native-navbar copied to clipboard

Published 20 hours ago • verified publisher icon Kureev

upgrade examples so that they are compatible with latest react-native version

Open liusy182 opened this issue 9 years ago • 4 comments

Examples were still based on older versions of react-native which is not compatible with latest versions. This PR upgrades examples so that they are compatible with current version of react-native.

liusy182 avatar Oct 30 '16 03:10 liusy182

Hi @liusy182!

Thanks for your contribution! Have you checked if it still works after this PR?

Kureev avatar Oct 31 '16 15:10 Kureev

Hi @Kureev, I have checked all examples on iOS and they all worked. I did not check android though.

liusy182 avatar Oct 31 '16 23:10 liusy182

Would be nice if somebody who has some time (can I ask you, @satya164?) try Android examples first before I merge it in.

Kureev avatar Nov 01 '16 10:11 Kureev

I'll test that tonight. BTW what do you think about migrating the example to exponent? It'll be super -easy for people to try it out then. And we don't have any native code in the repo which we need to update on RN updates.

Should be easy to convert to exponent using exp convert command.

satya164 avatar Nov 01 '16 10:11 satya164