react-native-navbar icon indicating copy to clipboard operation
react-native-navbar copied to clipboard

Published 20 hours ago • verified publisher icon Kureev

Support TitleComponent

Open BOOLRon opened this issue 9 years ago • 6 comments

BOOLRon avatar May 24 '16 08:05 BOOLRon

Merge this please

amyb87 avatar Aug 19 '16 17:08 amyb87

somebody can merge this?

yezongyang avatar Dec 13 '16 10:12 yezongyang

I probably miss something, but how is it different from what we have in place currently? https://github.com/react-native-community/react-native-navbar/blob/master/examples/CustomElements/index.ios.js#L19

Kureev avatar Dec 14 '16 11:12 Kureev

And yeah, sorry for not reviewing this PR for a long time. PRs without description goes to the bottom of my priority list (because motivation is not clear + I need to dive into the code to understand what author wanted to say)

Kureev avatar Dec 14 '16 11:12 Kureev

I thought that the customTitle is not inflexible

yezongyang avatar Dec 16 '16 06:12 yezongyang

@yezongyang can you be so kind to elaborate? In my mind, with customTitle you can supply your own title component and customize it however you want. Where is inflexibility?

Kureev avatar Dec 16 '16 12:12 Kureev