Kronopt

Results 39 comments of Kronopt
trafficstars

Hi, bladeoflight16. I bumped the `requests `version to 2.21 because of [this vulnerability](https://nvd.nist.gov/vuln/detail/CVE-2018-18074) with version

Yes. I haven't tested `beckett` with a different `requests` version though.

Yes, we could. I just don't think @phalt is interested in maintaining `beckett` anymore, as I've left some unanswered issues and a PR's there over the years. So I don't...

I just brushed over the code and it looks good, @C-Garza! I didn't test it though. I just have one comment: This way you have the requirements for both implementations...

@C-Garza a separate module would be best yes, in my opinion

Use real responses (stored as json) for testing

I've been thinking about adding support for pagination. I might eventually. When I do, it will cover every available resource, not just pokemon.

I think a general pagination issue would be better. But yeah, feel free to open it, yes! You can also try to implement this feature yourself, if you think you...

Hey GeoffreyFrogeye, thanks for the PR! You just made me realize that the `location_area_encounters` attribute of the `pokemon` resource is just a string with a link. @Naramsim @tdmalone why isn't...

Other comments: > If it were up to me I'd swap PokemonEncounter and LocationAreaEncounter so the name matches the anchor point of the encounter and not the attributes inside. What...