Shouldn't the delegate and datasources be weak?

[Ricardo1980]

I see this in the source code.

// DATASOURCE/DELEGATE fileprivate let itemsDelegate: GalleryItemsDelegate? fileprivate let itemsDataSource: GalleryItemsDataSource fileprivate let pagingDataSource: GalleryPagingDataSource

Shouldn't they be weak?

[yaddaa]

Really? I have memory problems when set myself as dataSource and keeping in memory

[RuiAAPeres]

Hmm, this might have been a slight oversight when designing it, or there could be a good reason, anyway, @Ricardo1980 can you give it a spin in the demo project?

[gabrielgava]

This will clearly cause a memory leak unless the caller explicitly dispose the GalleryViewController.

[davuthdv]

I got the same issue too. How do u guys solve this?

[mikechan1234]

I got the same issue too. How do u guys solve this?

You can just pass it an object that conforms to GalleryItemsDataSource. Seems like a design flaw or as intended.