kotlinx.coroutines icon indicating copy to clipboard operation
kotlinx.coroutines copied to clipboard

In the test module, collect and report the actual uncaught exceptions

Open dkhalanskyjb opened this issue 3 years ago • 1 comments
trafficstars

An attempt to mitigate #1205.

dkhalanskyjb avatar Sep 12 '22 14:09 dkhalanskyjb

A draft because it's untested and I'm not sure about the whole ANDROID_DETECTED thing (in a separate commit). @qwwdfsad, what do you think of the general approach?

dkhalanskyjb avatar Sep 12 '22 14:09 dkhalanskyjb

@qwwdfsad, WDYT about this big rework? This is much less intrusive than the previous version, but it is still a bit unpleasant due to CoroutineExceptionHandler not being flexible enough. I described my thoughts about the underlying issue with CoroutineExceptionHandler here: https://github.com/Kotlin/kotlinx.coroutines/pull/3554

dkhalanskyjb avatar Dec 27 '22 14:12 dkhalanskyjb

Let's finalize and merge it?

qwwdfsad avatar Feb 06 '23 10:02 qwwdfsad

(preliminary looks good, will take a one final look when #3603 is merged)

qwwdfsad avatar Feb 17 '23 17:02 qwwdfsad

Could you please rebase this one on the recent develop?

qwwdfsad avatar Feb 21 '23 18:02 qwwdfsad

Sure, done.

dkhalanskyjb avatar Feb 22 '23 11:02 dkhalanskyjb

I squashed the commits into one and wrote a detailed commit message. Did you have something like that in mind?

dkhalanskyjb avatar Feb 23 '23 13:02 dkhalanskyjb

Exactly, nicely done!

qwwdfsad avatar Feb 23 '23 16:02 qwwdfsad