kotlinx-datetime icon indicating copy to clipboard operation
kotlinx-datetime copied to clipboard

Fix Instant parsing on Native being too lenient

Open dkhalanskyjb opened this issue 3 years ago • 1 comments

dkhalanskyjb avatar Jan 18 '22 13:01 dkhalanskyjb

First we need to discuss what behavior we want from Instant.parse. In java.time, for example, Instant.parse does support times like 23:59:60Z.

ilya-g avatar Jan 18 '22 14:01 ilya-g

Closing in favor of #251

dkhalanskyjb avatar Nov 29 '23 15:11 dkhalanskyjb

I believe we still should discuss how to address an inconsistency between platforms if there is any.

ilya-g avatar Dec 08 '23 03:12 ilya-g

With #251, there isn't: the test from https://github.com/Kotlin/kotlinx-datetime/pull/251/commits/ca34c0abb0bbc935a7524d2ec24a84564a3e9972 passes for all platforms.

dkhalanskyjb avatar Dec 08 '23 09:12 dkhalanskyjb

There's no inconsistency between platforms in kotlinx.datetime, but there's inconsistency between kotlinx.datetime and java.time in Instant.parse. Let's reopen.

ilya-g avatar Dec 16 '23 18:12 ilya-g

Ok: #332

dkhalanskyjb avatar Dec 18 '23 11:12 dkhalanskyjb