kotlinx-benchmark icon indicating copy to clipboard operation
kotlinx-benchmark copied to clipboard

Support Gradle Project Isolation

Open dmitry-stakhov opened this issue 1 year ago • 6 comments
trafficstars

Here we use findProperty function that looks to another Gradle Projects and break the Gradle sync with enabled Project isolation feature:

property benchmarks_jmh_version of :benchmarks
Project :benchmarks cannot dynamically look up a property in the parent project :

Possible solution can be to use providers.gradleProperty("benchmarks_jmh_version").orNull instead.

dmitry-stakhov avatar Sep 10 '24 08:09 dmitry-stakhov

@dmitry-stakhov can you assign me this issue?

deep4nsh avatar Jan 07 '25 18:01 deep4nsh

@deep4nsh, you can take the issue.

fzhinkin avatar Jan 07 '25 18:01 fzhinkin

Thanks.

deep4nsh avatar Jan 07 '25 18:01 deep4nsh

I forked the repo and commited the solution. @fzhinkin @dmitry-stakhov

deep4nsh avatar Jan 07 '25 19:01 deep4nsh

@deep4nsh please open a pull request once you are ready to contribute the change.

fzhinkin avatar Jan 07 '25 19:01 fzhinkin

yes done

deep4nsh avatar Jan 07 '25 20:01 deep4nsh