messenger-kafka icon indicating copy to clipboard operation
messenger-kafka copied to clipboard

Adds support for failure message during serialization and handling

Open rdotter opened this issue 5 years ago • 1 comments

This solves: https://github.com/KonstantinCodes/messenger-kafka/issues/22

When a message is received and there is an MessageDecodingFailedException thrown during serialization or an exception during handling a WorkerMessageFailedEvent will be dispatched.

@KonstantinCodes

rdotter avatar Nov 10 '20 16:11 rdotter

Hi @rdotter! Great to see your PR :)

I know we talked about this feature a while ago, and your case definitely makes sense.

Still, I'm a bit unsure about basically making reject() do the same as ack(). It kind of feels like a workaround for code that throws too many Exceptions. (And blocks message processing that way.)

It really strikes me like the same could be achieved with a CatchAllExceptionsMiddleware.

KonstantinCodes avatar Nov 10 '20 23:11 KonstantinCodes