Konstantin Scheumann

Results 31 comments of Konstantin Scheumann

@splatch Yes, you're right. I think it's a good idea to fetch the Public Key from the server. We would need to implement a caching mechanism for that however and...

@ralfbecker Thanks for letting us know! I think this is great, but does require an extra HTTP request to the IDP. I'd hope to polish this pr so that you...

@derrabus thank you for your review! I'll get started with the fixes tomorrow. Actual integration tests are possible. I have a test that writes and reads. I see there is...

Oh nice. What about travis though? This test run (Unit Tests) fails because of the missing rdkafka.

Thank you for all the comments, I'll try to push changes today to accommodate them :)

@fabpot Yes, absolutely. I'd like to push a commit this week and then ask for another review.

@nicolas-grekas Sure, I take it, we should use a Stamp for the message key then instead of using the array returned by the serializer to read this value? @jderusse Made...

@fabpot I'll rebase the branch and fix the tests :)

@torbenbr hey, thank you for asking! Actually, the build system was puzzling me. Maybe we can take a look at that together?

@javiereguiluz Yes, that's gonna work 👍