feat(proxy-wasm) metrics

[casimiro]

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 94.05405% with 33 lines in your changes missing coverage. Please review.

Project coverage is 90.55212%. Comparing base (223a346) to head (3c18dda).

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main        #530         +/-   ##
===================================================
+ Coverage   90.37921%   90.55212%   +0.17291%     
===================================================
  Files             47          49          +2     
  Lines          10311       10849        +538     
===================================================
+ Hits            9319        9824        +505     
- Misses           992        1025         +33     

Files	Coverage Δ
src/common/proxy_wasm/ngx_proxy_wasm.h	91.89189% <ø> (ø)
src/common/shm/ngx_wasm_shm.h	100.00000% <ø> (ø)
src/common/shm/ngx_wasm_shm_kv.c	97.57282% <100.00000%> (+0.20439%)	:arrow_up:
src/wasm/ngx_wasm.h	100.00000% <ø> (ø)
src/wasm/ngx_wasm_core_module.c	92.64706% <ø> (ø)
src/wasm/ngx_wasm_directives.c	96.42857% <100.00000%> (+0.80356%)	:arrow_up:
src/common/metrics/ngx_wa_histogram.c	99.09091% <99.09091%> (ø)
src/common/proxy_wasm/ngx_proxy_wasm_properties.c	89.18919% <78.57143%> (-0.36998%)	:arrow_down:
src/ngx_wasmx.c	89.31298% <81.25000%> (-1.12181%)	:arrow_down:
src/common/proxy_wasm/ngx_proxy_wasm_host.c	94.09722% <92.37288%> (-0.28030%)	:arrow_down:
... and 1 more

... and 2 files with indirect coverage changes

Flag	Coverage Δ
unit	90.29341% <93.52818%> (+0.14415%)	:arrow_up:
valgrind	81.92417% <94.09369%> (+0.71011%)	:arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

[thibaultcha]

@casimiro I'm looking at coverage which looks mostly good except for this branch (open ngx_proxy_wasm_host.c file), I'm wondering how come it isn't covered, since I'm sure we have histogram tests already?

[casimiro]

@thibaultcha thank you for the new round of review!

I'm surprised as well with the missing coverage in ngx_proxy_wasm_host.c. I'm pretty sure I saw those lines covered before. I'll investigate that.

[github-advanced-security[bot]]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[thibaultcha]

I think I looked at everything now and the changeset looks all good. Once the last couple things are addressed I'll do a local merge with the minor stuff like docs wording, style etc which I left out of reviews. Let me know when ready!

[thibaultcha]

@casimiro Before pushing to this branch again, could you rebase it on the latest main for the CodeQL changes, so that the code analysis integration doesn't get confused again (I deleted all old CodeQL results from the CI workflow).

[casimiro]

@thibaultcha thank you for the reviews. The PR is ready.