kubernetes-ingress-controller icon indicating copy to clipboard operation
kubernetes-ingress-controller copied to clipboard

Add INFO log for admissions which aren't allowed

Open dweber019 opened this issue 1 year ago • 4 comments

What this PR does / why we need it:

It will add a INFO log message when an admission isn't allowed. This helps debugging and monitoring.

Which issue this PR fixes:

Fixes #6084

PR Readiness Checklist:

Complete these before marking the PR as ready to review:

  • [x] the CHANGELOG.md release notes have been updated to reflect any significant (and particularly user-facing) changes introduced by this PR

dweber019 avatar May 25 '24 13:05 dweber019

@pmalek related too https://github.com/Kong/kubernetes-ingress-controller/pull/6087 Thx

dweber019 avatar May 27 '24 13:05 dweber019

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 27 '24 10:06 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

:white_check_mark: dweber019
:white_check_mark: programmer04
:x: lahabana
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 27 '24 10:06 CLAassistant

@lahabana please sign CLA and we're good to go

programmer04 avatar Jul 10 '24 08:07 programmer04

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 74.2%. Comparing base (811148a) to head (98db664). Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #6086   +/-   ##
=====================================
  Coverage   74.1%   74.2%           
=====================================
  Files        202     202           
  Lines      20492   20539   +47     
=====================================
+ Hits       15198   15244   +46     
- Misses      4274    4287   +13     
+ Partials    1020    1008   -12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 11 '24 04:10 codecov[bot]