LuaFormatter icon indicating copy to clipboard operation
LuaFormatter copied to clipboard

git:// no longer supported by GitHub and fails to install

Open mblayman opened this issue 3 years ago • 1 comments

LuaFormatter is failing to install because of a recent change from GitHub. Here's my GitHub Actions job failing to install LuaFormatter.

which lua-format || luarocks --tree .luarocks install --server https://luarocks.org/dev luaformatter
Cloning into 'LuaFormatter'...
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.

Installing https://luarocks.org/dev/luaformatter-scm-1.rockspec
Error: Failed cloning git repository.

https://github.com/mblayman/atlas/runs/6168576509?check_suite_focus=true if the job in context.

I suspect the problem is from https://github.com/Koihik/LuaFormatter/blob/master/luaformatter-scm-1.rockspec#L5. The details about the change are on the GitHub blog.

I think it can be fixed by changing the protocol from git:// to git+https://. I don't know if this will require a new version pushed to LuaRocks.

mblayman avatar Apr 26 '22 02:04 mblayman

This might be related to #252.

Also, the rockspec on luarocks still uses the git protocol: https://luarocks.org/manifests/tammela/luaformatter-scm-1.rockspec

@tammela if you could fix this; thanks.

xbc5 avatar Jul 28 '22 21:07 xbc5