php-github-api icon indicating copy to clipboard operation
php-github-api copied to clipboard

Why defaults don't match the github doc?

Open penja opened this issue 6 years ago • 3 comments

For example current user api handler link in type field has owner value as default but according github api we link have all as default.

P.S If necessary, I can fix it by PR.

Thanks for this awesome library.

penja avatar Jul 01 '19 09:07 penja

Changing this would be a breaking change, so I don't think we should.

GrahamCampbell avatar Jul 01 '19 10:07 GrahamCampbell

Ok thanks we can close this issue.

penja avatar Jul 01 '19 10:07 penja

It would indeed be a BC break to change that value now, but maybe a better solution is to move these options into a parameters/options parameter of the function and leave all option empty by default so they will fallback to github defaults. This way our lib doesn't set defaults that will be outdated sometime in the future.

I will assign the 3.0 milestone to this issue, so we can handle this possible cleanup in the future!

acrobat avatar Aug 05 '19 19:08 acrobat