KnpRadBundle icon indicating copy to clipboard operation
KnpRadBundle copied to clipboard

[DataTable] "bootstrap" option should be renamed to "theme".

Open docteurklein opened this issue 12 years ago • 2 comments
trafficstars

And we should be able to decalre them through configuration maybe. For the moment, it's too error prone.

docteurklein avatar May 15 '13 07:05 docteurklein

Currently there is a restriction due to the build of theme path :

'KnpRadBundle:Twig:Datatable/' . $options['bootstrap'] . '/datatable.html.twig'

This prevents any other theme provider than "KnpRadBundle:Twig:Datatable" folder.

So I suggest to externalize "Default" and "Bootstrap" theme into a config file, and to inject the theme list to the TwigExtension, enabling too to specify which theme is the default one.

smalot avatar May 15 '13 08:05 smalot

Yes, would be far better!

docteurklein avatar May 27 '13 07:05 docteurklein