KnpDisqusBundle icon indicating copy to clipboard operation
KnpDisqusBundle copied to clipboard

SSO service is overwritten

Open dantleech opened this issue 7 years ago • 2 comments

It seems the $parameters['sso']['service'] is overwritten here, and the generated value from getSsoParameters does not include the service.

dantleech avatar Jan 24 '18 16:01 dantleech

Specifically the Disqus class will only include the existing sso parameters if the user config key is set - and in our application (and any other?) we only set this key if the user is logged in.

The SSO service should be set regardless of logged in status.

dantleech avatar Jan 24 '18 16:01 dantleech

Dan - do you have a fix you could propose? Nobody super maintains this bundle, but I’d certainly be happy to merge a pr and tag.

weaverryan avatar Jan 24 '18 18:01 weaverryan