Knockout-Validation icon indicating copy to clipboard operation
Knockout-Validation copied to clipboard

Published 20 hours ago • verified publisher icon Knockout-Contrib

When adding a rule, use 'peek' to check the existing rules.

Open petemill opened this issue 9 years ago • 3 comments
trafficstars

This is so that any encapsulating subscriptions won't fire if the rules change.

See #594.

petemill avatar Nov 25 '15 22:11 petemill

If I'm right in thinking that addRule does not need to be re-processed if observable.rules() changes, then the peek used in this PR is probably more appropriate. As suggested by @mbest.

petemill avatar Nov 25 '15 22:11 petemill

Thanks @petemill @mbest. I'm going to merge this but after I make some tests against KO 3.4 to and see if there are any other related issues.

crissdev avatar Nov 26 '15 19:11 crissdev

Merged into v2.1.0 branch. The PR will close itself when merged into master. Thanks for your contribution.

Fixes #594

crissdev avatar Dec 08 '15 21:12 crissdev