klipper icon indicating copy to clipboard operation
klipper copied to clipboard

Allow Klippy to listen to a TCP socket

Open Toniob opened this issue 9 months ago • 9 comments

This PR is to allow Klippy to listen to a TCP socket. The changes are backward compatible with the current configuration. It allows to use unix:// url to bind to a unix socket or tcp:// for the new features.

I’ve modified whconsole.py to test my patch and everything seems to be fine.

Toniob avatar Feb 17 '25 16:02 Toniob

Thankyou for submitting a PR, please be aware you need to sign off, as per point 3 in https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md#what-to-expect-in-a-review

Thanks James

JamesH1978 avatar Feb 18 '25 09:02 JamesH1978

Sorry for this oversight. I’ve just changed my commit. I hope it’s better this way.

Toniob avatar Feb 18 '25 09:02 Toniob

@Toniob I can suggest to update the docs too

lexfrei avatar Feb 18 '25 16:02 lexfrei

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

  1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
  2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
  3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

github-actions[bot] avatar Mar 05 '25 00:03 github-actions[bot]

Thanks. From the conversation at https://klipper.discourse.group/t/make-the-api-listens-to-a-tcp-socket/21939/13 it seems there is some concern from some of the other long-term contributors (eg, security, duplication with moonraker, limited audience). I'd be inclined to hold off on this until there's a clear audience of a notable size that requires something like this (we typically aim for a minimum of at least a 100 users for changes to the main Klipper repo): https://www.klipper3d.org/CONTRIBUTING.html

-Kevin

KevinOConnor avatar Mar 07 '25 22:03 KevinOConnor

@KevinOConnor look at https://hub.docker.com/r/mkuf/moonraker please. We can't speak about users count here, but 50k downloads is a big number for a non-official image. We can divide 50k by tags count (120) assuming that each user used each tag once and it's 400+ of users. Each of them needs this feature.

lexfrei avatar Mar 08 '25 23:03 lexfrei

Very interested in this. Some printers have resource issues and this would enable to free up resources.

lisbonc1987 avatar Mar 12 '25 10:03 lisbonc1987

Need this now.

alund1990 avatar Mar 12 '25 14:03 alund1990

Cool, great fix/addition

NetBUG avatar Mar 13 '25 14:03 NetBUG

I would love to see this added, this will be a boon for people with cheapo printers

shvetsm avatar May 11 '25 12:05 shvetsm

Found this due to the pitiful performance of the Flashforge 5M SBC. Offloading to an external host like this would be awesome.

Twisticles avatar May 14 '25 05:05 Twisticles

Another user reporting that I'd love this feature

Would also happily accept some amount of limitations to mitigate the very valid security concerns if it moves us in the direction of getting this merged into klipper and moonraker - maybe requiring a shared 256-bit secret between the two?

ankushg avatar Jun 24 '25 01:06 ankushg

I would also love this one!

jatinkrmalik avatar Jul 04 '25 04:07 jatinkrmalik

I'd also like this feature to be implemented.

farhankamili avatar Jul 22 '25 03:07 farhankamili