Gerrit Uitslag
Gerrit Uitslag
Issue [FS#2776](https://bugs.dokuwiki.org/index.php?do=details&task_id=2776) complains about the case where the limit was respected, but that DokuWiki doesn't provide explain that to its user. Issue [FS#2472](https://bugs.dokuwiki.org/index.php?do=details&task_id=2472) about failing do to lack of memory.
The fix for FS#2425 checks for 3 locations and shows the smallest: https://github.com/splitbrain/dokuwiki/commit/f940e4a0129ffeefd746c0ebdb25132413e388c0 Is it possible for you to obtain the numbers for each of them? - post_max_size - suhosin.post.max_value_length...
We have unit tests for the different syntaxes, here these for tables and preformatted blocks: https://github.com/dokuwiki/dokuwiki/blob/master/_test/tests/inc/parser/parser_table.test.php https://github.com/dokuwiki/dokuwiki/blob/master/_test/tests/inc/parser/parser_preformatted.test.php Could you add tests as well for the new cases? that might prevent...
And nice to see the results of the puzzle, thanks for the effort!
The unit tests are part of the development snapshot. I assume they are not delivered with a stable download. More background is available at https://www.dokuwiki.org/devel:unittesting Ideally unit tests are created...
The latest commit did also trigger the execution of the unit tests on GitHub. See for example the [php8.0 run](https://github.com/dokuwiki/dokuwiki/actions/runs/6151614762/job/16692041031?pr=4055) for the results. It shows that we have about 32...
For the fileuploader is used a small javascript library valums Ajax Upload (old site: http://valums.com/ajax-upload/) , which is not maintained any more. See for last maintenance attempt: https://github.com/Valums-File-Uploader/file-uploader So far...
A predecessor for the Valums file uploader is the Fine-file-uploader https://github.com/FineUploader/fine-uploader, which has a MIT license according to https://github.com/Valums-File-Uploader/file-uploader/issues/58, but it is unfortunately not maintained anymore. An nice alternative seems...
It is more then just checking extension probably. My impression is that these checks here are for switching between handling as image or as non-image. For that check indeed a...
If simple check, without involving mime config, is working, I propose not to add it. Only add it if really needed, please keep things simple as possible.