dive icon indicating copy to clipboard operation
dive copied to clipboard

[BUG] Undeletable dataset entry in dataset list

Open mattdawkins opened this issue 3 years ago • 11 comments
trafficstars

I'm not sure how it got into this state

transcode_error_desktop

mattdawkins avatar Jan 05 '22 20:01 mattdawkins

I think this happens when a user deletes VIAME_DATA manually

mattdawkins avatar Jan 05 '22 22:01 mattdawkins

You should be able to use this button to resync the data in the folder and this will remove any lingering dead datasets: image

BryonLewis avatar Jan 06 '22 13:01 BryonLewis

Naive user isn't going to know that or it won't be obvious, instead of error condition on an unsynced folder maybe it should just remove them from list?

mattdawkins avatar Jan 06 '22 18:01 mattdawkins

I think it would be reasonable to gray out or outright remove missing items if they're not on disk. The trouble is when DIVE should attempt to figure out that there was a change. We could put in some kind of inotify support or something but it would be a pretty complex change.

@BryonLewis, is there something small we can do to improve UX around this problem?

waxlamp avatar Jan 12 '22 22:01 waxlamp

On launch we may be able to a quick auto sync with the dataset (For most people hopefully this is quick). Then on launching or trying to delete a non-existent dataset we can give them an option to sync, that way they don't have jump to a separate section of the interface to run it.

ghost avatar Jan 12 '22 23:01 ghost

On launch we may be able to a quick auto sync with the dataset (For most people hopefully this is quick). Then on launching or trying to delete a non-existent dataset we can give them an option to sync, that way they don't have jump to a separate section of the interface to run it.

I like this approach.

waxlamp avatar Jan 12 '22 23:01 waxlamp

I'm concerned about running this on launch. It's a disk crawl. Disk may be filled with lots of data or otherwise very low I/O such as a network mount. We know some people use a network mount like this. There's no way to know how long such an operation will take.

subdavis avatar Jan 13 '22 02:01 subdavis

I thought there was a reason we didn't check it on launch. So maybe we provide the a button on failure to delete/launch because of missing data. Then we provide a mechanism for the user to exit out of the process if it is taking a significant amount of time?

BryonLewis avatar Jan 13 '22 11:01 BryonLewis

Another tidbit of info, but when I press sync, the entries disappear from the current running instance of DIVE. However, when I reboot, they're still in the list and still undeletable.

mattdawkins avatar Jan 14 '22 18:01 mattdawkins

How many dive desktop instances do you have open? You may be hitting #907

subdavis avatar Jan 14 '22 18:01 subdavis

I think I only had 1 that I was using at once, though not 100%.

As an alternative to potential large load issues, you wouldn't necessarily need to check every image file, just that the high level folders are there at least, or the first image file in each sequence. 99% of the time that would do it, at least for my use cases and that wouldn't be slow cause it's just a O(1) check for each video.

mattdawkins avatar Jan 17 '22 15:01 mattdawkins