react-a11y-dialog icon indicating copy to clipboard operation
react-a11y-dialog copied to clipboard

Is this library compatible with React 19?

Open jgarplind opened this issue 11 months ago • 2 comments

Is this library compatible with React 19?

I don't see any instant reason why not, so I would submit a PR bumping the peer dependency to v19, but that is assuming that there is nothing breaking that I'm not aware of.

If you want to give it a look yourself and are not fully up to speed, here's a helpful resource to evaluate the (not so big in my opinion) breaking changes: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#breaking-changes

jgarplind avatar Jan 05 '25 21:01 jgarplind

Hello Joel,

That is a good question! My gut feeling is that it should be, but it would need to be tried out. If you have capacity to give it a go, and everything works, then feel free to bump the peer dep. :)

KittyGiraudel avatar Jan 06 '25 07:01 KittyGiraudel

At present it throws an error because React 19 isn't listed as an option in the peer dependencies.

npm error Could not resolve dependency:
npm error peer react@"^16.8.0 || ^17 || ^18" from [email protected]
npm error node_modules/react-a11y-dialog
npm error   react-a11y-dialog@"^7.4.0" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.

I'm using this package on Docusaurus. Docusuarus 4 will require React 19, at which point this package will become incompatible.

techbridgedev avatar Jan 07 '25 16:01 techbridgedev

Solved in 7.4.1.

KittyGiraudel avatar Jun 07 '25 13:06 KittyGiraudel