Koban token

[VSBDev]

trafficstars

Description

Kinto Koban Token as a tokenization template

Type of change

• [ ] Bug fix
• [X] New feature
• [ ] Breaking change
• [ ] Dependency changes
• [ ] Deployment
• [ ] Forge Script
• [ ] Code refactor / cleanup
• [ ] Documentation or wording changes
• [ ] Other

Checklist:

• [X] The diff is legible and has no extraneous changes
• [X] Complex code has been commented, including external interfaces
• [X] Tests have 100% code coverage
• [X] The base branch is either main, or there's a description of how to merge

Issue Resolution

[openzeppelin-code[bot]]

Koban token

Generated at commit: d90ac801096e89340a37489b7b9c2e2261cb1b89

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 1 0 12 41 57
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 73.68421% with 20 lines in your changes missing coverage. Please review.

Project coverage is 89.07%. Comparing base (db29b09) to head (2f17273). Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
src/tokens/KintoKoban.sol	73.68%	20 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #280      +/-   ##
==========================================
- Coverage   89.84%   89.07%   -0.77%     
==========================================
  Files          34       36       +2     
  Lines        1753     1831      +78     
==========================================
+ Hits         1575     1631      +56     
- Misses        178      200      +22     

Files with missing lines	Coverage Δ
src/tokens/KintoKoban.sol	73.68% <73.68%> (ø)

... and 2 files with indirect coverage changes

[rrecuero]

My main comment is that this is more an example that a standard. Take a look at the base ERC20 contracts or the Vault EIP. This should be a baseclass that has the functions and the user can use it by inheriting and extending