Fix KintoInflator

[ylv-io]

Description

Before 265418

After 138734

• Fixes the bug related to limited byte size for user operations.
• Reduces the number of lines by 55.
• Improves gas efficiency for simple UserOperations by 48%, with even greater improvements for larger operations.

Can be gas golfed more with assembly. A good work test for a Solidity dev.

Type of change

• [x] Bug fix
• [ ] New feature
• [ ] Breaking change
• [ ] Dependency changes
• [ ] Deployment
• [ ] Forge Script
• [ ] Code refactor / cleanup
• [ ] Documentation or wording changes
• [ ] Other

Checklist:

• [x] The diff is legible and has no extraneous changes
• [x] Complex code has been commented, including external interfaces
• [x] Tests have 100% code coverage
• [x] The base branch is either main, or there's a description of how to merge

Issue Resolution

[openzeppelin-code[bot]]

Fix KintoInflator

Generated at commit: 70ea1a99d27dd6df931f4c3275fd99f7bf50d213

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	3 1 0 12 40 56
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[github-actions[bot]]

Slither report

THIS CHECKLIST IS NOT COMPLETE. Use --show-ignored-findings to show all the results. Summary

• arbitrary-send-eth (4 results) (High)

arbitrary-send-eth

Impact: High Confidence: Medium

• [ ] ID-0 BaseAccount._payPrefund(uint256) sends eth to arbitrary user Dangerous calls:
  • (success,None) = address(msg.sender).call{gas: type()(uint256).max,value: missingAccountFunds}()

https://github.com/KintoXYZ/kinto-core/blob/d681e6c2379cb0419afe8addb04d346581172f20/node_modules/account-abstraction/contracts/core/BaseAccount.sol#L118-L127

• [ ] ID-1 Governor._execute(uint256,address[],uint256[],bytes[],bytes32) sends eth to arbitrary user Dangerous calls:
  • (success,returndata) = targets[i].call{value: values[i]}(calldatas[i])

https://github.com/KintoXYZ/kinto-core/blob/d681e6c2379cb0419afe8addb04d346581172f20/node_modules/openzeppelin-contracts/governance/Governor.sol#L363-L375

• [ ] ID-2 Governor.relay(address,uint256,bytes) sends eth to arbitrary user Dangerous calls:
  • (success,returndata) = target.call{value: value}(data)

https://github.com/KintoXYZ/kinto-core/blob/d681e6c2379cb0419afe8addb04d346581172f20/node_modules/openzeppelin-contracts/governance/Governor.sol#L593-L596

• [ ] ID-3 BaseAccount._payPrefund(uint256) sends eth to arbitrary user Dangerous calls:
  • (success,None) = address(msg.sender).call{gas: type()(uint256).max,value: missingAccountFunds}()

https://github.com/KintoXYZ/kinto-core/blob/d681e6c2379cb0419afe8addb04d346581172f20/node_modules/account-abstraction-0.7.0/contracts/core/BaseAccount.sol#L103-L112

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.55%. Comparing base (4cac8b4) to head (70ea1a9). Report is 12 commits behind head on main.

Files	Patch %	Lines
src/inflators/KintoInflator.sol	89.47%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   89.74%   88.55%   -1.20%     
==========================================
  Files          33       33              
  Lines        1746     1730      -16     
==========================================
- Hits         1567     1532      -35     
- Misses        179      198      +19     

Files	Coverage Δ
src/inflators/KintoInflator.sol	86.89% <89.47%> (-13.11%)	:arrow_down: