kinto-core icon indicating copy to clipboard operation
kinto-core copied to clipboard

Add support for using a second signer (HW)

Open fedealconada opened this issue 1 year ago • 1 comments

Description

This PR adds support for using a second signer on the KintoWallet.

This second signer is a Hardware Wallet that could either be "ledger" or "trezor".

I've provided a sample migration (script/migrations/65-test-wallet-change.s.sol) with how this can be used. There's no need to execute the migration (but if done, it won't do any change).

Type of change

  • [ ] Bug fix
  • [x] New feature
  • [ ] Breaking change
  • [ ] Dependency changes
  • [ ] Deployment
  • [x] Code refactor / cleanup
  • [ ] Documentation or wording changes
  • [ ] Other

Checklist:

  • [ ] The diff is legible and has no extraneous changes
  • [ ] Complex code has been commented, including external interfaces
  • [ ] Tests have 100% code coverage
  • [ ] The base branch is either main, or there's a description of how to merge

Issue Resolution

fedealconada avatar May 22 '24 14:05 fedealconada

Add support for using a second signer (HW)

Generated at commit: 0fd89b1eac179d7b9c0276dfbd10c545a71700ff

🚨 Report Summary

Severity Level Results
Contracts Critical High Medium Low Note Total 3 1 0 11 40 55
Dependencies Critical High Medium Low Note Total 0 0 0 0 0 0

For more details view the full report in OpenZeppelin Code Inspector

openzeppelin-code[bot] avatar May 22 '24 14:05 openzeppelin-code[bot]