SDK: Overall review comments

Open lakshmih opened this issue 1 year ago • 1 comments

We tried running the SDK as is and have some comments/ feedback on specific samples. Creating an issue so we can discuss this.

cllayerinfo - No Output from the sample

nbodycpp - Passes but animation does not close conwaycpp - Passes but animation does not close

saxpy - Fails with: Verification failed! -9127.552734 != -9127.553711 at index 1 Error: CL_INVALID_VALUE

saxpycpp - Fails with: Error: Verification FAILED!

For the first two tests, we should perhaps improve the sample to provide meaningful output and to exit cleanly. In general, interested in checking if these samples behave the same on other implementations as well.

Rest of the samples look okay on initial review / run.

General comment that it would be useful for samples to log something to stdout if everything ran successfully,.

Nov 19 '24 18:11 lakshmih

Discussed in the December 3rd teleconference:

For cllayerinfo, we filed https://github.com/KhronosGroup/OpenCL-ICD-Loader/issues/247 for tracking.
For saxpy and saxpycpp, Qualcomm will investigate why the sample is failing on their implementation. It's possible there is an error in the sample, but we haven't seen failures on other implementations.
The graphical applications are behaving as expected, and will not close automatically.

Dec 07 '24 00:12 bashbaug