OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

Published 20 hours ago • verified publisher icon KhronosGroup

Fix profiling_timebase error, the global work size shouldn't be NULL,…

Open jujiang-del opened this issue 9 months ago • 4 comments

… according to OpenCL specification

jujiang-del avatar Feb 20 '25 17:02 jujiang-del

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Feb 20 '25 17:02 CLAassistant

See https://github.com/KhronosGroup/OpenCL-CTS/pull/2241

bashbaug avatar Feb 20 '25 19:02 bashbaug

This PR is not merged yet, and the issue is still seen. Could anyone help merge it by any chance?

jujiang-del avatar Aug 22 '25 17:08 jujiang-del

Hi! This PR hasn't been merged because a NULL global work size is valid. We recently merged a change to the OpenCL specification to clarify this because the requirement was documented in a strange place previously, see: https://github.com/KhronosGroup/OpenCL-Docs/pull/1381 and the related issue https://github.com/KhronosGroup/OpenCL-Docs/issues/1302.

Please note that we have also added targeted testing for these scenarios to ensure drivers are behaving as described in the spec, see: https://github.com/KhronosGroup/OpenCL-CTS/pull/2378 and the related issue https://github.com/KhronosGroup/OpenCL-CTS/issues/2244.

I'd probably be OK merging this PR or something like it personally, since I don't think it's an important part of the test scenario to have a NULL global work size, but I'm also not sure it's worth the bother. Assuming your implementation is passing the zero_sized_enqueue API tests, is there still an issue in this profiling_timebase test?

bashbaug avatar Aug 22 '25 20:08 bashbaug