OpenCL-CTS icon indicating copy to clipboard operation
OpenCL-CTS copied to clipboard

Fix oob in test_conformance/Test_vStoreHalf

Open pursuezhao opened this issue 3 years ago • 6 comments

Out-of-bound access happens when off is not less than lim.

pursuezhao avatar Jun 10 '22 00:06 pursuezhao

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Jun 10 '22 00:06 CLAassistant

hi there, could anyone help to review this change?

pursuezhao avatar Jun 14 '22 23:06 pursuezhao

Hi, can you please check that you (or your company) has signed the Contributor License Agreement (see https://github.com/KhronosGroup/OpenCL-CTS/pull/1434#issuecomment-1151767261)? We won't be able to merge this change otherwise. Thanks!

bashbaug avatar Jun 15 '22 15:06 bashbaug

Hi, can you please check that you (or your company) has signed the Contributor License Agreement (see #1434 (comment))? We won't be able to merge this change otherwise. Thanks!

hi, thanks for your kindly reminding, I have signed the license agreement.

pursuezhao avatar Jun 16 '22 00:06 pursuezhao

Hi, can you please check that you (or your company) has signed the Contributor License Agreement (see #1434 (comment))? We won't be able to merge this change otherwise. Thanks!

hi, could you help to have a review on this change?

pursuezhao avatar Jun 16 '22 07:06 pursuezhao

I tried this git branch locally, but none of these new conditions checking for oob were hit when run against our implementation.

Would you be able to elaborate on what the values of off and lim are which these if statements catch? From a skim of the code lim seems derived from BUFFER_SIZE which is constant, but off can be influenced by the thread count. I tried running the test with 1, 3, 8, & 24 threads but couldn't see the oob.

EwanC avatar Jun 24 '22 10:06 EwanC