OpenCL-CTS Extend test coverage for `clClonekernel`

Add the following test coverage for the clCloneKernel

With args: Use clSetKernelArg to set args after kernel is cloned. Enqueue and read the buffer to validate.

With Execinfo: Use clSetKernelExecInfo after the kernel is cloned and read the buffer to validate.

With no args: Clone a kernel with no args and enqueue.

With SVM pointer: Use clSetKernelArgSVMPointer to set args after kernel is cloned. Enqueue and read the buffer to validate.

This fixes #1098 and #1234

This PR also replaces test_error with test_assert_error to report the error during failure.

May 14 '21 16:05 jainvikas8

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

May 14 '21 16:05 CLAassistant

I'm seeing

fatal: unable to access 'https://github.com/KhronosGroup/libclcxx.git/': Could not resolve host: github.com
Command exited with code 128

How can we restart this?

May 17 '21 08:05 jainvikas8

@gwawiork, please review.

May 17 '21 15:05 jainvikas8

I'm seeing

fatal: unable to access 'https://github.com/KhronosGroup/libclcxx.git/': Could not resolve host: github.com
Command exited with code 128

How can we restart this?

I had the same issue on another PR. I ended up re-pushing (on the same branch) to retrigger another run. Hopefully there's a more clever alternative with a simple button to press somewhere, but I couldn't find it.

May 19 '21 07:05 mantognini

Forced pushed to rebase.

Jun 02 '21 13:06 jainvikas8

Forced pushed again, CI was stuck

Jun 10 '21 15:06 jainvikas8

Hi @jainvikas8 I've check your changes on Windows on Intel GPU and I am getting ERROR: clFinish failed! (CL_OUT_OF_RESOURCES from C:\NewVPG\Repo\public-github\opensource-qb\OpenCL-CTS\test_conformance\api\test_clone_kernel.cpp:524) test_exec_enqueue_helper failed for cloneKernel_2 on retry. clCloneKernel test_cloned_kernel_exec_info failed. clone_kernel FAILED

The test process is not able to exit looks like hang. Could you double check on your side if everything is ok ? I will analyze the problem as well.

Aug 05 '21 13:08 gwawiork

Forced pushed to rebase.

Aug 05 '21 15:08 jainvikas8

Hi @jainvikas8 I've check your changes on Windows on Intel GPU and I am getting ERROR: clFinish failed! (CL_OUT_OF_RESOURCES from C:\NewVPG\Repo\public-github\opensource-qb\OpenCL-CTS\test_conformance\api\test_clone_kernel.cpp:524) test_exec_enqueue_helper failed for cloneKernel_2 on retry. clCloneKernel test_cloned_kernel_exec_info failed. clone_kernel FAILED

The test process is not able to exit looks like hang. Could you double check on your side if everything is ok ? I will analyze the problem as well.

Have not observed this in the past, normally it should fail for this too. test_exec_enqueue_helper failed for cloneKernel_1 on the retry Will look into reproducing this issue. Thanks.

Aug 06 '21 10:08 jainvikas8

Forced pushed to rebase and add 2 new commits to address the review comments.

Aug 23 '21 14:08 jainvikas8

Hi @jainvikas8 I've check your changes on Windows on Intel GPU and I am getting ERROR: clFinish failed! (CL_OUT_OF_RESOURCES from C:\NewVPG\Repo\public-github\opensource-qb\OpenCL-CTS\test_conformance\api\test_clone_kernel.cpp:524) test_exec_enqueue_helper failed for cloneKernel_2 on retry. clCloneKernel test_cloned_kernel_exec_info failed. clone_kernel FAILED The test process is not able to exit looks like hang. Could you double check on your side if everything is ok ? I will analyze the problem as well.

Have not observed this in the past, normally it should fail for this too. test_exec_enqueue_helper failed for cloneKernel_1 on the retry Will look into reproducing this issue. Thanks.

@gwawiork I've been unable to reproduce this issue on MALI-GPU in Linux with OpenCL 2.1 and 3.0. So, please let me know your thoughts on this?

Aug 23 '21 14:08 jainvikas8

@jainvikas8 Please take a look at my review when you have the time.