genqlient icon indicating copy to clipboard operation
genqlient copied to clipboard

Published 20 hours ago • verified publisher icon Khan

Fix `optional` default value

Open knao124 opened this issue 3 years ago • 2 comments
trafficstars

changes

  • fix optional default value in docs/genqlient.yaml

issue

current yaml causes an unmarshal error like below

line 14: cannot unmarshal !!map into string

see: https://github.com/Khan/genqlient/blob/main/generate/config.go#L34

knao124 avatar Sep 01 '22 06:09 knao124

Thanks for catching this! It looks good to me; could you please sign the Khan Academy CLA?

benjaminjkraft avatar Sep 06 '22 20:09 benjaminjkraft

@knao124 let us know when you've signed the CLA!

csilvers avatar Sep 28 '22 16:09 csilvers

This is easy enough to fix I'll just redo it to avoid CLA issues.

benjaminjkraft avatar Oct 24 '22 00:10 benjaminjkraft