emacs-syncthing icon indicating copy to clipboard operation
emacs-syncthing copied to clipboard

Icons don't show

Open Igor1257 opened this issue 1 year ago • 4 comments
trafficstars

image

image

on Windows 10 GNU Emacs 29.1 (build 2, x86_64-w64-mingw32) of 2024-01-02

Igor1257 avatar May 23 '24 15:05 Igor1257

@Igor1257 What font do you use in that buffer (or in Emacs overall)?

KeyWeeUsr avatar May 23 '24 15:05 KeyWeeUsr

Oh, thanks. I set (set-face-attribute 'default nil :family "Hack Nerd Font" :height 100)

and now looks better

image

Igor1257 avatar May 24 '24 06:05 Igor1257

@KeyWeeUsr please suggest which font is preferred.

Igor1257 avatar May 27 '24 05:05 Igor1257

@Igor1257 /usr/share/fonts/truetype/dejavu/DejaVuSansMono.ttf is the default font I've been using on multiple Linux boxes because it's been simply set as the default for monospace font. Although it seems to work fine for all of the icons it might be useful to add a customization value which would strip all of the icons or even allow setting up custom ones :thinking:

KeyWeeUsr avatar May 31 '24 00:05 KeyWeeUsr

Solved in 2.3.0 by providing both ASCII mode and support for themes where icons can be chosen from:

  1. list of themes
  2. custom theme implemented as per the examples below the default one.

KeyWeeUsr avatar Nov 22 '24 23:11 KeyWeeUsr

Please reconsider reopening the bug. Even the current themes, and especially the default theme, use symbols from the Private Use Area of the Unicode table. Depending on the font in use (also in the terminal), this can result in quite messy output.

Knusper avatar Dec 29 '24 13:12 Knusper

@Knusper Hmmm, do you have a set of symbols that are working for you? :thinking: I could add it as a new theme, perhaps set as the default if it's applicable to more fonts? Otherwise I'm unsure how would you like to solve this problem except by either using pure ASCII or having an own theme where you specify what works for you (or replace the symbols in a theme with "") since there will always be differences between fonts no matter the symbol I use.

KeyWeeUsr avatar Dec 29 '24 15:12 KeyWeeUsr

How about using the all-the-icons package in emacs. In non-graphical emacs one needs then to support only UTF-8 symbols outside the private use area of the unicode block. These are standardized amongst different unicode fonts. A different solution might be to require a specific font family for the buffers in graphical buffers.

Knusper avatar Dec 29 '24 21:12 Knusper

@Knusper 👋 I added a new theme using All The Icons. Feel free to give it a try. https://github.com/KeyWeeUsr/emacs-syncthing/blob/9c69be95d3979cd4aa15896206fa69d8465039ae/syncthing-themes.el#L132

KeyWeeUsr avatar May 28 '25 23:05 KeyWeeUsr