slice-group-by
slice-group-by copied to clipboard
LinearGroupByKey could allow provided closure to borrow from input
Fixed #25 Let me know if any changes are required
Thank you for the changes @CodeMan62 🙏
However, it's very hard to review this small lifetime addition when it's mixed with format changes. Would you mind doing the fmt in a dedicated commit, please?
I see the CI failing and I was also wondering if you could add the lifetime definition on the other methods, not only the
linear_group_byone.
No need for please :smile: I will do this and also try to add the lifetime definitions on the other methods, and yes, if there's something I can implement more in this project, let me know.
@Kerollmops I have added lifetime to almost all the functions :pray: .
@Kerollmops can you please review the code with fmt I have added more changes this time please?
let me do all the work in one commit.
Thanks @Kerollmops for help in this PR
Hey @CodeMan62 👋
Unfortunately, thanks to this comment. It is not sound to make this change on *GroupByMut iterators. You'll have to expand the macros, generating both mut and non-mut iterators, yourself to change the signature for both implementations 🥺
Hey @Kerollmops let me see what i can do EDIT:- Finally found time to work on it