slice-group-by icon indicating copy to clipboard operation
slice-group-by copied to clipboard

LinearGroupByKey could allow provided closure to borrow from input

Open CodeMan62 opened this issue 7 months ago • 7 comments
trafficstars

Fixed #25 Let me know if any changes are required

CodeMan62 avatar Apr 07 '25 04:04 CodeMan62

Thank you for the changes @CodeMan62 🙏

However, it's very hard to review this small lifetime addition when it's mixed with format changes. Would you mind doing the fmt in a dedicated commit, please?

I see the CI failing and I was also wondering if you could add the lifetime definition on the other methods, not only the linear_group_by one.

No need for please :smile: I will do this and also try to add the lifetime definitions on the other methods, and yes, if there's something I can implement more in this project, let me know.

CodeMan62 avatar Apr 15 '25 15:04 CodeMan62

@Kerollmops I have added lifetime to almost all the functions :pray: .

CodeMan62 avatar Apr 18 '25 19:04 CodeMan62

@Kerollmops can you please review the code with fmt I have added more changes this time please?

CodeMan62 avatar Apr 29 '25 12:04 CodeMan62

let me do all the work in one commit.

CodeMan62 avatar Apr 30 '25 18:04 CodeMan62

Thanks @Kerollmops for help in this PR

CodeMan62 avatar May 02 '25 09:05 CodeMan62

Hey @CodeMan62 👋

Unfortunately, thanks to this comment. It is not sound to make this change on *GroupByMut iterators. You'll have to expand the macros, generating both mut and non-mut iterators, yourself to change the signature for both implementations 🥺

Kerollmops avatar May 02 '25 12:05 Kerollmops

Hey @Kerollmops let me see what i can do EDIT:- Finally found time to work on it

CodeMan62 avatar May 02 '25 12:05 CodeMan62