receive_sharing_intent
receive_sharing_intent copied to clipboard
KasemJaffer
Use customizable app group id
With these changes you can define your own app group id instead of group.BUNDLE_ID by putting it into the Info.plist. If no AppGroupId is found in the Info.plist file it will use the old convention instead.
(I transferred my app from one apple account to another and lost my app group id by that. So the old approach of this repo wasn't working anymore.)
@KasemJaffer I highly recommend to look at this and try to merge in into master :-)
There are some use-cases for the group id not being the same as group.bundle_id.
I tested this (I had to because of our architecture, I cannot simply use group.bundle_id.
@Klabauterman maybe you could squash the commits (at least the last 2 into the example adaptation). Why did you remove the test code?
Hey guys, I am sorry, i totally forgot about my PR. I'll check your comments today.
@GRBurst commits are squashed, readme corrected, intend fixed, example code changed
Hey @Klabauterman, I'm still very thankful since I use your PR in my app for quite some time now :+1:
I think your last commit (0ede807) should be on a different branch since it does not directly relate to the PR.
@KasemJaffer Again I'd really appreciate if you could consider to merge this. It really solves some real world issues. Please make a statement whether or not you are going to merge it and what issues you see towards merging it ;-)
Thank you all for the great work. I'm closing this because i merged this other PR which has the same functionality. I will be releasing v1.5.0 as soon as possible after i run some testes.
