AnkiconnectAndroid icon indicating copy to clipboard operation
AnkiconnectAndroid copied to clipboard

versioning

Open IzzySoft opened this issue 1 year ago • 2 comments

Looks like you forgot to increase the versionCode with the last release (1.14):

Binary files /web/ftp/repo/fdroid/repo/com.kamwithk.ankiconnectandroid_13.apk and /web/ftp/repo/fdroid/repo/com.kamwithk.ankiconnectandroid_1.14.apk differ

Which means that v1.13 had versionCode: 13 and v1.14 had the same – so the update won't reach anyone (as wherever v1.13 is installed, v1.14 will be considered by Android as "already there" because Android goes by versionCode).

Too late now for 1.14 (as it's already rolled out), so please do not replace the APK at the tag/release. But please ensure to remember for future releases :wink:

PS: feel free of course to create a "maintenance release" like 1.14.1 so it reaches those running v1.13.

PPS: As I see no badges in the Readme, and you might wonder where I'm reporting from: your app is listed here and can be installed and kept up-to-date with an F-Droid client of choice. Be welcome to pick a badge to link there from e.g. your Readme if you wish :smiley:

IzzySoft avatar Jul 26 '24 19:07 IzzySoft

Hey thanks for letting me know! I always forget that and in the past before actually having it somewhere I normally just did update it on the fly aha

I will create a v1.14.1 release soon to fix the issue, and adding in a badge doesn't sound like a bad idea either 👀

KamWithK avatar Jul 27 '24 13:07 KamWithK

I should look if there's something like a "pre-tag" hook. Then I could offer that to "the forgetful". Something like: "check if versionCode(now) is bigger than versionCode(last_tag). If not, reject." Should be possible I guess… Though the docs on hooks don't mention it :cry: But something like this post-receive-hook example could work, if you want to look into it.

And thanks for considering the badge! :smiley:

IzzySoft avatar Jul 27 '24 17:07 IzzySoft

I will create a v1.14.1 release soon

soon™ 🙊 Friendly reminder, as people already reporting to the repos (e.g. at IzzyOnDroid) assuming we missed the release… So any chance, @KamWithK?

IzzySoft avatar Apr 18 '25 13:04 IzzySoft

I will create a v1.14.1 release soon

soon™ 🙊 Friendly reminder, as people already reporting to the repos (e.g. at IzzyOnDroid) assuming we missed the release… So any chance, @KamWithK?

Hey sorry that's totally my fault

I have a few PRs at the moment I'd like to get in and then after that I'll definitely cut the next release

KamWithK avatar Apr 27 '25 09:04 KamWithK

Thanks @KamWithK – no complaints! As stated, just a "friendly reminder" in case it "went under" 😉 (and a "request for information" if it's still on the table 🙈)

IzzySoft avatar Apr 27 '25 10:04 IzzySoft

Thanks @KamWithK – no complaints! As stated, just a "friendly reminder" in case it "went under" 😉 (and a "request for information" if it's still on the table 🙈)

Hey I have pushed my new release and I did bump the version numbers this time so we should be all good now!

KamWithK avatar Jun 22 '25 11:06 KamWithK

Thanks! That went through smoothly. Will show up with the next sync then 😃

IzzySoft avatar Jun 22 '25 11:06 IzzySoft