hotspot icon indicating copy to clipboard operation
hotspot copied to clipboard

ignore empty command line arguments

Open GitMensch opened this issue 1 year ago • 5 comments
trafficstars

Those can be passed by tools calling HotSpot and lead to "File '' does not exist." error messages.

One example "tool" is vscode - you can either start external programs with no arguments or with user-inputs (for example a , but if you have an empty user input (aka "just start hotspot") you get that error message.

GitMensch avatar Jun 07 '24 18:06 GitMensch

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

GitMensch avatar Jun 07 '24 19:06 GitMensch

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option).

Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

milianw avatar Jun 15 '24 22:06 milianw

Hm, thinking about that; maybe it would be nice to allow opening hotspot without "perf.data", even if it exists - this could also be triggered by the empty file "" (or a new binary option). Thoughts?

Up to you, if you see a need for it I'm not going to oppose a patch for that.

I think if we extend #660 to start on several pages (for starters at least "recording" and "open") this issue is solved. Please have a look there any comment about a possible --startPage or how you'd name an option.

GitMensch avatar Jun 21 '24 11:06 GitMensch

@GitMensch I wouldn't prefix the commit with chore since that should be used to dependency updates. Use feat in this case.

lievenhey avatar Sep 17 '24 10:09 lievenhey

done

GitMensch avatar Sep 17 '24 11:09 GitMensch

thanks!

milianw avatar Nov 19 '24 12:11 milianw