hotspot icon indicating copy to clipboard operation
hotspot copied to clipboard

Published 20 hours ago • verified publisher icon KDAB

Automate release

Open lievenhey opened this issue 1 year ago • 1 comments
trafficstars

This PR adds an automatic latest release aswell as release-please which provides a pr that can be merged to create a new release.

closes: #605

lievenhey avatar Apr 29 '24 13:04 lievenhey

I am not sure if the build-appimage pipeline should be deactivated on the master branch, since the create-latest-release pipeline will take care of that.

lievenhey avatar Apr 29 '24 13:04 lievenhey

I currently fail to understand that - the idea is that for each commit on master there is a "continuous" release, no? Then I don't see where that release is, which then would solve the now closed #605.

GitMensch avatar May 03 '24 19:05 GitMensch

https://github.com/KDAB/hotspot/releases/tag/continuous here but it seems I need to figure something out since it was marked as draft. Will deal with this on Monday. Good find, thanks.

lievenhey avatar May 03 '24 20:05 lievenhey

Ah, now I see that as it should be: a pre-release release. If that is automatically updated, then this would be fine. Can you adjust it so that it gets an additional asset with a fixed name like hoptspot-continuous.AppImage? Note: interesting to see that the release-push via GH action allows an .AppImage, while @milianw couldn't upload that extension (I assume via GH online adjustment of the release) any more and needed to gzip that up-front. Maybe it won't work over the GH API in the future, or it would be useful to do it similar for "real releases".

GitMensch avatar May 03 '24 20:05 GitMensch

Done, seems like ether ncipollo/release-action or github automatically add a draft tag. Now I use the github cli to remove that tag.

I don't think changing the name to hotspot-continuous.AppImage is a good idea. The current name is a perfect description of the commit that was used to build the appimage. If we get a bug report we can then use the name to identify which exact version was used. Maybe the bug is already fixed but the user didn't update, etc ...

lievenhey avatar May 06 '24 13:05 lievenhey

./hotspot... --version has the output, as well as the version info in the GUI. The idea here is to get a stable download URL, and for that we need - additional to the updated release - an identical name.

If you still want the versioned name: what do you think about having the appimage twice (once with a stable name)?

GitMensch avatar May 06 '24 15:05 GitMensch