hotspot icon indicating copy to clipboard operation
hotspot copied to clipboard

fix source code search

Open lievenhey opened this issue 1 year ago • 2 comments
trafficstars

The search functions only works on a limited range, but the model contained the complete source code. This patch runs the search function on only a subset of that code. fixes: #577

lievenhey avatar Jan 16 '24 14:01 lievenhey

Is there any option to adjust the search model test for that case?

GitMensch avatar Jan 16 '24 21:01 GitMensch

I rewrote the search functions to use iterators instead + added some tests

lievenhey avatar Jan 22 '24 13:01 lievenhey

Looking forward to get this merged.

GitMensch avatar Feb 28 '24 15:02 GitMensch

I've pot some time into testing the appimage - the source handling in the Disassembly window now seems to work fine.

The only thing that feels strange is the go to function:

  • seems to be only usable with the context menu
  • CTRL+G is identical to ALT+G and selects/closes the Flame Graph; I guess that's the QT default we want to keep *but maybe CTRL+SHIFT+G can then open the go to dialogue as well

And of course #523 and #528 as well as #607 would be very helpful.

GitMensch avatar Apr 23 '24 09:04 GitMensch