hotspot icon indicating copy to clipboard operation
hotspot copied to clipboard

fix multiline highlighting was ~add ci test for non optional build~

Open lievenhey opened this issue 1 year ago • 12 comments
trafficstars

This commit adds a ci build to build hotspot without optional dependencies. This should prevents bugs like #575 (fails to build without qcustomplot).

lievenhey avatar Jan 16 '24 11:01 lievenhey

I encountered a similar problem when I tried debugging my changes. In that case it was impossible to build hotspot without KSyntaxHighlighter. The ci update should catch that in the future.

lievenhey avatar Jan 16 '24 11:01 lievenhey

Nice, the ci found the first bug already

lievenhey avatar Jan 16 '24 11:01 lievenhey

Multi line comments are now highlighted correctly grafik

lievenhey avatar Jan 16 '24 14:01 lievenhey

dammit, it broke the disassembler

lievenhey avatar Jan 16 '24 14:01 lievenhey

now it is working correctly

lievenhey avatar Jan 16 '24 14:01 lievenhey

Nice work!

the PR's title may should be adjusted, or the changes split into two PRs (I don't think that's necessary as long as it is split in the commits)

GitMensch avatar Jan 16 '24 21:01 GitMensch

I split the ci change off into its own pr

lievenhey avatar Jan 22 '24 10:01 lievenhey

I do wonder if not resetting the highlighter has any performance impact

GitMensch avatar Jan 22 '24 10:01 GitMensch

It has. Until this patch the Highlighter was called on demand. Now it is called once for the whole file.

lievenhey avatar Jan 22 '24 13:01 lievenhey

I guess that's good to go after solving the merge conflict.

GitMensch avatar Jan 24 '24 11:01 GitMensch

Just wondering: Is there anything blocking the pull here?

GitMensch avatar Feb 05 '24 12:02 GitMensch

Milians high workload.

lievenhey avatar Feb 06 '24 10:02 lievenhey