hotspot icon indicating copy to clipboard operation
hotspot copied to clipboard

Tracepoint

Open lievenhey opened this issue 2 years ago • 10 comments
trafficstars

Show tracepoints in TimeLineWidget

lievenhey avatar Sep 21 '23 11:09 lievenhey

image

lievenhey avatar Sep 21 '23 16:09 lievenhey

somehow making sure that the favorite rows are always shown, independent of the vertical current scroll position - potentially through a second view?

using a second view is most likely the easiest option since QWidgets don't have stuff like qmls header or footer

lievenhey avatar Oct 05 '23 11:10 lievenhey

somehow making sure that the favorite rows are always shown, independent of the vertical current scroll position - potentially through a second view?

using a second view is most likely the easiest option since QWidgets don't have stuff like qmls header or footer

Agreed, we just need to sync the views and show just a single header somehow. But this should/ could be done in a follow-up patch and doesn't necessarily block integration of the work here as long as the other important issues are resolved.

milianw avatar Oct 07 '23 09:10 milianw

Is this still in a draft state? It seems that new testcases are now available (but failing) are there still missing ones?

GitMensch avatar Nov 14 '23 14:11 GitMensch

@milianw I finally found some time to work in this. Can you check if it to your satisfaction?

lievenhey avatar Nov 28 '23 14:11 lievenhey

are you sure you pushed the correct work? I don't think you attended the issue I raised above, namely:

the biggest issue is that all tracepoints for all threads and processes are lumped together into a single row - that is pretty useless.

I just checked out your branch, rebased it on master and ran it on data I obtained with

perf record -z --call-graph dwarf -e cycles -e raw_syscalls:sys_enter -e raw_syscalls:sys_exit ./tests/test-clients/cpp-parallel/cpp-parallel

The result is still a single list of tracepoints across all threads, which is not useful. What's worse, some threads are suddenly showing up multiple times in the timelines above?

Screenshot_20231210_124332

milianw avatar Dec 10 '23 11:12 milianw

Ok, fixed that. Now all events are shown in one line (before there was one line per even type). That is still somewhat wip since now it is really hard to differentiate different event types since only the tooltip reveals the type. I propose the following:

  • different colors for different event types
  • when hovering highlight not only all stacks but also all symbols with the same type

lievenhey avatar Jan 15 '24 16:01 lievenhey